[SEARCHEXP-1358]Handle relative path and resolve to their real path#164
Merged
Merged
Conversation
Arnau González (arnaugm)
previously approved these changes
Jun 9, 2023
| ? bpkReactScriptsConfig.babelIncludePrefixes.map( | ||
| (prefix) => new RegExp(`node_modules[\\/]${prefix}`) | ||
| ) | ||
| ? bpkReactScriptsConfig.babelIncludePrefixes.map(prefix => { |
There was a problem hiding this comment.
are we able to add unit tests for this at all?
There was a problem hiding this comment.
That would be a good idea, added.
but seems BRS is lacking unit tests and there is no process in the pipeline to run the unit test automatically(I couldn’t find it if I don’t miss something), in this case, seems adding unit tests for this change doesn’t make much sense. Seems the test facility in BRS is not fully equipped, what do you think 🤔️
| { | ||
| "name": "@skyscanner/backpack-react-scripts", | ||
| "version": "10.4.0", | ||
| "version": "10.4.1", |
There was a problem hiding this comment.
This should happen after PR is merged and new version is released.
There was a problem hiding this comment.
Good to know, thanks!
Christopher Moore (runmoore)
approved these changes
Jun 27, 2023
Arnau González (arnaugm)
approved these changes
Jul 3, 2023
mungodewar
pushed a commit
that referenced
this pull request
Jul 11, 2023
…164) * handle relative path * remove console.log * handle relative path * unformat * update version * add unit test * revert change log --------- Co-authored-by: gc.zhu <gc.zhu@skyscanner.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Ticket: SEARCHEXP-1358
Investigation and decision log: Decision log
For the consumer side, it will fail to compile when importing a typed logic from the
commonpackage, which is imported by npm local importWe discussed the proposals listed in this decision log, and we all agree to adopt Option 3 as a medium-term option before new potential production standard carry out. That is 👇：
ℹ️ We will release a beta version first, and verify in CI that this works in other microsites. Once everything goes well, we will release a main version
How to solve it
Screenshots
Compile and build successfully in Banana with the changes
